Trying to figure out rivers

ook, I had tea break so why not:

public void FindRiverCrossings()
{
//for each river in the world
foreach (RiverData rd in riversStart)
{
RiverData thisNode = rd;
RiverData nextNode = rd.next;

while (nextNode != null)
{
//each two river nodes HAVE TO HAVE 2 common neighbours.
List<Vector3i> pair = new List<Vector3i>();
foreach(Vector3i neighbour in rd.neighbours)
{
if (nextNode.neighbours.Contains(neighbour) )
{
pair.Add(neighbour);
}
if (pair.Count == 2) break;
}

Hex a = GetHexAt(pair[0]);
Hex b = GetHexAt(pair[1]);

if (a.viaRiverHashSet == null)
{
a.viaRiverHashSet = new HashSet<Hex>();
}
if (a.viaRiverHashSet.Contains(b))
{
a.viaRiverHashSet.Add(b);
}

if (b.viaRiverHashSet == null)
{
b.viaRiverHashSet = new HashSet<Hex>();
}
if (b.viaRiverHashSet.Contains(a))
{
b.viaRiverHashSet.Add(a);
}
}
}
}


you may need to add public variable to Hex class:
public HashSet<Hex> viaRiverHashSet;

and this function to World class

Note its written in notepad, so its untested, but shoudl be better than pseudo code

ah I just realized this code is missing advancing on river nodes.

thisNode = nextNode;
nextNode = nextNode.next;

and logic is wrong, eg:
if (a.viaRiverHashSet.Contains(b))
should be
if (!a.viaRiverHashSet.Contains(b))

see this is why coding is much easier when you do that in the editor or at least reading what you write

hmm I'm not really sure why it would not work, are you sure you are not calling it on the interpolated river data?

This is a screenshot of a river I generated with it's next nodes. Also the import is fresh (I re-imported it to check if it was something I have changed).



There is a method call in GetNeighbors called IsNextToThisPoint(pos) and this method returns true if the offset between pos and the hex position is 0.5. This can never be true for river nodes that are not with a decimal .5
Hope I explained myself better. I'm going to try rounding all river nodes to .5 , maybe it works. Thanks again for your time.

EDIT 1: I have debugged all the river generation in CreateRivers code and the river nodes were generated as expected with .5 decimals. I'm guessing that somewhere else the position is being altered and it's losing it's .5 decimal to something like .4293

I don't understand what you mean by interpolated values. The nodes shown there are of 1 river that starts from 2.5, -4.5, 1.5 and ends at -0.25, 3.25, 3.5 ( which when generated it's actually fine but than gets messed up values after generation). I am using the method that you gave me for finding river crossings, so I should be using the correct variables.



The problem is occuring here:

O my god I am so dumb, there was already a method that did this in the original one, all I hadto do is use the list variable in the hexes called directionsPassingRiver which is exactly what I was trying to implement but works perfectly since the list is generated before the post process. Sorry for wasting so much of your time but I really appreciate the help and have learned a lot. Thanks for the wonderful package I'll go write a nice review on the asset store page for you Bdw nice game you have there on steam, congrats.